Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation to config.php for share_folder #15931

Merged
merged 1 commit into from
Jun 12, 2019

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jun 12, 2019

Fix #9726

From original issue:

Changes to this value will only have effect on new shares. Existing shares are listed in the share_folder valid at the time of the creation of the share.

I felt like the Existing shares are listed in the share_folder valid at the time of the creation of the share part is not very clear, anyone knows what it means?

Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv added enhancement 3. to review Waiting for reviews labels Jun 12, 2019
@skjnldsv skjnldsv added this to the Nextcloud 17 milestone Jun 12, 2019
@skjnldsv skjnldsv self-assigned this Jun 12, 2019
@georgehrke
Copy link
Member

I felt like the Existing shares are listed in the share_folder valid at the time of the creation of the share part is not very clear, anyone knows what it means?

The name of the folder that existing shares are in will always be named like 'share_folder' at the time the user created the share. It's basically the same statement from the first sentence.

@ChristophWurst
Copy link
Member

anyone knows what it means?

Nope 🤷‍♂️

@skjnldsv
Copy link
Member Author

Ok, so let's get this in like that then!

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 12, 2019
@skjnldsv skjnldsv merged commit dc9e73a into master Jun 12, 2019
@skjnldsv skjnldsv deleted the Add-documentation-to-config.php-for-share_folder branch June 12, 2019 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation to config.php for share_folder
4 participants